https://github.com/bulbazord commented:

I think I follow what this PR is supposed to do, but I had some trouble 
following the implementation. I added some comments inline to explain where I 
was confused.

As an overall suggestion, I think you should add a test case for providers with 
the same priority level. I'm not sure what the intended order is in that case. 
If any order is possible, you should write a test that checks all scenarios.

https://github.com/llvm/llvm-project/pull/172849
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to