https://github.com/JDevlieghere approved this pull request.

LGTM. Listing those languages is correct for `GetSupportedLanguagesForTypes` 
(as opposed to `GetSupportedLanguagesForExpressions`). Even more robust would 
be to say that `TypeSystemClangSupportsLanguage` should return the union of 
those two, but in practice that's already the case. 

Normally I'm a big proponent of splitting up PRs if it makes sense and would 
agree with Michael, but I think this is borderline.

https://github.com/llvm/llvm-project/pull/172567
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to