================
@@ -9,22 +9,43 @@
 #ifndef LLDB_TOOLS_LLDB_DAP_VARIABLES_H
 #define LLDB_TOOLS_LLDB_DAP_VARIABLES_H
 
+#include "Protocol/ProtocolTypes.h"
 #include "lldb/API/SBValue.h"
 #include "lldb/API/SBValueList.h"
 #include "llvm/ADT/DenseMap.h"
+#include <map>
+#include <utility>
 
-#define VARREF_FIRST_VAR_IDX (int64_t)4
-#define VARREF_LOCALS (int64_t)1
-#define VARREF_GLOBALS (int64_t)2
-#define VARREF_REGS (int64_t)3
+#define VARREF_FIRST_VAR_IDX (int64_t)1
 
 namespace lldb_dap {
 
-struct Variables {
-  lldb::SBValueList locals;
-  lldb::SBValueList globals;
-  lldb::SBValueList registers;
+enum ScopeKind { Locals, Globals, Registers };
----------------
Anthony-Eid wrote:

I wasn't sure if you wanted me to rename the enum name or the enum variants. I 
went with renaming the enum name to `eScopeKind` because the variants are 
always referenced with the enum name first, e.g. `eScopeKind::Locals`.

Please let me know if you wanted me to rename the enum variants so I can do so.

https://github.com/llvm/llvm-project/pull/124232
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to