https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/175955
This reverts: ``` Author: Adrian Prantl <[email protected]> Date: Tue Nov 4 08:29:47 2025 -0800 [LLDB] Don't check for libcxx if LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS is off ``` This was needed as an escape hatch for our ASAN bot because we couldn't build libc++ on it. Ever since https://github.com/llvm/llvm-zorg/pull/702 we can. Most people wouldn't know to `LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS` when building LLDB. Which means they'd never know to build libc++, and thus would have worse test-coverage for our data-formatters. If we really want such an escape hatch, we might want to name it something more explicit like `RELAX_DARWIN_LIBCXX_TEST_REQUIREMENTS`. An alternative is to enable `LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS` by default. >From f3049c6459831d24c5784ccd1c8109f06ea70deb Mon Sep 17 00:00:00 2001 From: Michael Buch <[email protected]> Date: Wed, 14 Jan 2026 13:59:20 +0000 Subject: [PATCH] [lldb][CMake] Don't condition libc++ requirement on LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS This reverts: ``` Author: Adrian Prantl <[email protected]> Date: Tue Nov 4 08:29:47 2025 -0800 [LLDB] Don't check for libcxx if LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS is off ``` This was needed as an escape hatch for our ASAN bot because we couldn't build libc++ on it. Ever since https://github.com/llvm/llvm-zorg/pull/702 we can. Most people wouldn't know to `LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS` when building LLDB. Which means they'd never know to build libc++, and thus would have worse test-coverage for our data-formatters. If we really want such an escape hatch, we might want to name it something more explicit like `RELAX_DARWIN_LIBCXX_TEST_REQUIREMENTS`. An alternative is to enable `LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS` by default. --- lldb/test/CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lldb/test/CMakeLists.txt b/lldb/test/CMakeLists.txt index 818dff58aceeb..513d1ec493ee1 100644 --- a/lldb/test/CMakeLists.txt +++ b/lldb/test/CMakeLists.txt @@ -202,7 +202,7 @@ if(TARGET clang) else() # We require libcxx for the test suite, so if we aren't building it, # provide a helpful error about how to resolve the situation. - if(LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS AND NOT LLDB_HAS_LIBCXX) + if(NOT LLDB_HAS_LIBCXX) message(SEND_ERROR "LLDB test suite requires libc++, but it is currently disabled. " "Please add `libcxx` to `LLVM_ENABLE_RUNTIMES` or disable tests via " _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
