llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-lldb Author: Alex Langford (bulbazord) <details> <summary>Changes</summary> Nothing overrides this method and the base class's implementation returns nullptr. --- Full diff: https://github.com/llvm/llvm-project/pull/177479.diff 2 Files Affected: - (modified) lldb/include/lldb/Symbol/ObjectFile.h (-23) - (modified) lldb/source/Core/Module.cpp (-9) ``````````diff diff --git a/lldb/include/lldb/Symbol/ObjectFile.h b/lldb/include/lldb/Symbol/ObjectFile.h index 0c9bf8fc03c63..01115a22aeda3 100644 --- a/lldb/include/lldb/Symbol/ObjectFile.h +++ b/lldb/include/lldb/Symbol/ObjectFile.h @@ -339,29 +339,6 @@ class ObjectFile : public std::enable_shared_from_this<ObjectFile>, /// virtual void RelocateSection(lldb_private::Section *section); - /// Appends a Symbol for the specified so_addr to the symbol table. - /// - /// If verify_unique is false, the symbol table is not searched to determine - /// if a Symbol found at this address has already been added to the symbol - /// table. When verify_unique is true, this method resolves the Symbol as - /// the first match in the SymbolTable and appends a Symbol only if - /// required/found. - /// - /// \return - /// The resolved symbol or nullptr. Returns nullptr if a - /// a Symbol could not be found for the specified so_addr. - virtual Symbol *ResolveSymbolForAddress(const Address &so_addr, - bool verify_unique) { - // Typically overridden to lazily add stripped symbols recoverable from the - // exception handling unwind information (i.e. without parsing the entire - // eh_frame section. - // - // The availability of LC_FUNCTION_STARTS allows ObjectFileMachO to - // efficiently add stripped symbols when the symbol table is first - // constructed. Poorer cousins are PECoff and ELF. - return nullptr; - } - /// Detect if this object file has been stripped of local symbols. /// Detect if this object file has been stripped of local symbols. /// diff --git a/lldb/source/Core/Module.cpp b/lldb/source/Core/Module.cpp index 0948136f30156..486af1a053344 100644 --- a/lldb/source/Core/Module.cpp +++ b/lldb/source/Core/Module.cpp @@ -514,15 +514,6 @@ uint32_t Module::ResolveSymbolContextForAddress( } sc.symbol = matching_symbol; - if (!sc.symbol && resolve_scope & eSymbolContextFunction && - !(resolved_flags & eSymbolContextFunction)) { - bool verify_unique = false; // No need to check again since - // ResolveSymbolContext failed to find a - // symbol at this address. - if (ObjectFile *obj_file = sc.module_sp->GetObjectFile()) - sc.symbol = - obj_file->ResolveSymbolForAddress(so_addr, verify_unique); - } if (sc.symbol) { if (sc.symbol->IsSynthetic()) { `````````` </details> https://github.com/llvm/llvm-project/pull/177479 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
