We've had a couple of cases of "dead" code which turned out to be the llvm.org side of generic behavior for which Swift was the only current specific implementation. So while I agree, little single functions that aren't used anywhere are fine to cull, anything that looks like it might be the former issue should probably be discussed first.
Jim > On Apr 19, 2017, at 8:43 AM, Zachary Turner via Phabricator via lldb-commits > <lldb-commits@lists.llvm.org> wrote: > > zturner accepted this revision. > zturner added a comment. > This revision is now accepted and ready to land. > > No need to request review when removing dead code. > > > https://reviews.llvm.org/D32148 > > > > _______________________________________________ > lldb-commits mailing list > lldb-commits@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits