labath created this revision. Herald added a subscriber: mgorny. All implementations of the connection interface live in the Host module already, so it makes sense for the interface itself to be defined there.
https://reviews.llvm.org/D34400 Files: include/lldb/Core/Connection.h include/lldb/Host/Connection.h include/lldb/Host/posix/ConnectionFileDescriptorPosix.h include/lldb/Host/windows/ConnectionGenericFileWindows.h source/Core/CMakeLists.txt source/Core/Communication.cpp source/Core/Connection.cpp source/Host/CMakeLists.txt source/Host/common/Connection.cpp source/Host/posix/ConnectionFileDescriptorPosix.cpp tools/lldb-server/Acceptor.h
Index: tools/lldb-server/Acceptor.h =================================================================== --- tools/lldb-server/Acceptor.h +++ tools/lldb-server/Acceptor.h @@ -9,7 +9,7 @@ #ifndef lldb_server_Acceptor_h_ #define lldb_server_Acceptor_h_ -#include "lldb/Core/Connection.h" +#include "lldb/Host/Connection.h" #include "lldb/Host/Socket.h" #include "lldb/Utility/Status.h" Index: source/Host/posix/ConnectionFileDescriptorPosix.cpp =================================================================== --- source/Host/posix/ConnectionFileDescriptorPosix.cpp +++ source/Host/posix/ConnectionFileDescriptorPosix.cpp @@ -20,6 +20,7 @@ #include "lldb/Host/Socket.h" #include "lldb/Host/SocketAddress.h" #include "lldb/Utility/SelectHelper.h" +#include "lldb/Utility/Timeout.h" // C Includes #include <errno.h> @@ -42,7 +43,6 @@ #include "llvm/ADT/SmallVector.h" #endif // Project includes -#include "lldb/Core/Communication.h" #include "lldb/Core/Timer.h" #include "lldb/Host/Host.h" #include "lldb/Host/Socket.h" Index: source/Host/common/Connection.cpp =================================================================== --- source/Host/common/Connection.cpp +++ source/Host/common/Connection.cpp @@ -7,7 +7,7 @@ // //===----------------------------------------------------------------------===// -#include "lldb/Core/Connection.h" +#include "lldb/Host/Connection.h" #if defined(_WIN32) #include "lldb/Host/windows/ConnectionGenericFileWindows.h" Index: source/Host/CMakeLists.txt =================================================================== --- source/Host/CMakeLists.txt +++ source/Host/CMakeLists.txt @@ -4,6 +4,7 @@ endmacro() add_host_subdirectory(common + common/Connection.cpp common/File.cpp common/FileCache.cpp common/FileSystem.cpp Index: source/Core/Communication.cpp =================================================================== --- source/Core/Communication.cpp +++ source/Core/Communication.cpp @@ -9,9 +9,9 @@ #include "lldb/Core/Communication.h" -#include "lldb/Core/Connection.h" #include "lldb/Core/Event.h" #include "lldb/Core/Listener.h" +#include "lldb/Host/Connection.h" #include "lldb/Host/HostThread.h" #include "lldb/Host/ThreadLauncher.h" #include "lldb/Utility/ConstString.h" // for ConstString Index: source/Core/CMakeLists.txt =================================================================== --- source/Core/CMakeLists.txt +++ source/Core/CMakeLists.txt @@ -7,7 +7,6 @@ ArchSpec.cpp Broadcaster.cpp Communication.cpp - Connection.cpp Debugger.cpp Disassembler.cpp DumpDataExtractor.cpp Index: include/lldb/Host/windows/ConnectionGenericFileWindows.h =================================================================== --- include/lldb/Host/windows/ConnectionGenericFileWindows.h +++ include/lldb/Host/windows/ConnectionGenericFileWindows.h @@ -10,7 +10,7 @@ #ifndef liblldb_Host_windows_ConnectionGenericFileWindows_h_ #define liblldb_Host_windows_ConnectionGenericFileWindows_h_ -#include "lldb/Core/Connection.h" +#include "lldb/Host/Connection.h" #include "lldb/Host/windows/windows.h" #include "lldb/lldb-types.h" Index: include/lldb/Host/posix/ConnectionFileDescriptorPosix.h =================================================================== --- include/lldb/Host/posix/ConnectionFileDescriptorPosix.h +++ include/lldb/Host/posix/ConnectionFileDescriptorPosix.h @@ -19,7 +19,7 @@ // Other libraries and framework includes // Project includes -#include "lldb/Core/Connection.h" +#include "lldb/Host/Connection.h" #include "lldb/Host/IOObject.h" #include "lldb/Host/Pipe.h" #include "lldb/Host/Predicate.h" Index: include/lldb/Host/Connection.h =================================================================== --- include/lldb/Host/Connection.h +++ include/lldb/Host/Connection.h @@ -31,7 +31,7 @@ namespace lldb_private { //---------------------------------------------------------------------- -/// @class Connection Connection.h "lldb/Core/Connection.h" +/// @class Connection Connection.h "lldb/Host/Connection.h" /// @brief A communication connection class. /// /// A class that implements that actual communication functions for
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits