charles-zablit wrote:

> Did some test cases started passing with this change? I sure hope so.

With this patch and https://github.com/llvm/llvm-project/pull/201141 combined, 
we are seeing 4 DAP tests pass with `LLDB_USE_LLDB_SERVER=1` on Windows. There 
will be one more passing once we get STDIN working.

> > This patch uses a default terminal size to create the ConPTY, which causes 
> > issues.
> 
> Here and/or in the other patch, please give an example of such an issue. I am 
> curious why these dimensions are key on Windows but not on Unixes.

Done in the other patch 👍 


https://github.com/llvm/llvm-project/pull/201124
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to