lhames added inline comments.
================
Comment at: source/Symbol/ClangExternalASTSourceCommon.cpp:24
+template <typename FnType>
+static decltype(std::declval<FnType>()(std::declval<ASTSourceMap&>()))
+WithExclusiveSourceMap(FnType fn) {
----------------
Does std::result_of<FnType>::type work as the return type?
http://en.cppreference.com/w/cpp/types/result_of
================
Comment at: source/Symbol/ClangExternalASTSourceCommon.cpp:28
static ASTSourceMap *s_source_map = new ASTSourceMap;
- return *s_source_map;
+ static std::mutex s_source_map_mutex;
+
----------------
Should this be on a context object of some kind (ASTContext?).
Repository:
rL LLVM
https://reviews.llvm.org/D35083
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
