https://github.com/da-viper approved this pull request.
LGTM but. I would prefer the new SBAPI `IsLiveDebugSession` to be split into its own PR, separate from the DAP changes. The PR title does not reflect the SBAPI change so it is easy to miss, and keeping it separate allows people more familiar with the SBAPI to review it in isolation and confirm there are no unexpected side effects. It would also make it easier to cherry-pick downstream. https://github.com/llvm/llvm-project/pull/202785 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
