https://github.com/labath approved this pull request.
#This fixes the issue I ran into. The patch looks good to me. I noticed one additional quirk when playing around with this. If I increase the window height abruptly (say, using the "maximize vertically") feature, then we end up with a bunch of blank lines between the prompt (which is at the bottom of the screen) and whatever was on the screen before the resize. If I resize the window slowly (so ~one line at a time), Then the blank lines don't show up, and the window fills with the lines that were previously not visible. Interestingly, this happens only once -- if I resize the window back-and-forth multiple times, we don't keep inserting new blank lines. While it would be better to fix this to always fill the screen with lines from the scrollback buffer (maybe you increased the window size so you could see more of the buffer), I don't think this is a blocker for this patch. https://github.com/llvm/llvm-project/pull/202691 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
