clayborg added a comment. A few inline fixes, but this looks great. Very close
================ Comment at: include/lldb/Core/ArchSpec.h:26-30 namespace lldb_private { class Platform; -} -namespace lldb_private { class Stream; -} -namespace lldb_private { class StringList; } ---------------- This should actually be removed and replaced with a lldb-forward.h file. I know it was wrong to begin with, but we should fix it as long as we are making changes. ================ Comment at: include/lldb/Core/Architecture.h:17 + +class Architecture { +public: ---------------- This should inherit from PluginInterface so we can extract the plug-in name from it if needed for logging. ================ Comment at: include/lldb/Core/Architecture.h:19 +public: + Architecture() = default; + virtual ~Architecture() = default; ---------------- Not sure the constructor is needed? https://reviews.llvm.org/D31172 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits