Timmmm wrote: Some notes:
1. No AI was used to make this PR. 2. I haven't added tests, but I have verified that this works manually using OpenOCD connected to a RISC-V CPU simulation. If a test is required I might need some help (see https://github.com/llvm/llvm-project/pull/203204#issuecomment-4679384445). To be honest I don't know if I'll have time (I'm changing jobs soon and this fix is needed for my current job) so I thought a fix with no test is at least better than no fix. 3. I didn't add logging that notification packets are dropped. I can add that if desired. 4. I also could use a `switch` instead of `==` if desired. That has the nicer property that when refactors add enum variants you get an error/warning that they aren't handled in all the `switch`es, but not where you use `==`. Also... > Since this is your first PR, here are a few useful links... Erm, it's not? #203204 - Something wrong with your bot I think! https://github.com/llvm/llvm-project/pull/204788 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
