https://github.com/DavidSpickett commented:
If this PR had had unittests from the beginning, I wouldn't be advocating for an API test too. However, maybe it's because I wrote the test case, but I think we should keep the API test on the grounds that it looks like the original bug report and unit tests don't add much on top. Hopefully the natural timing variance of the API test will cover things like single read of the buffer versus multiple and so on. LGTM, but let's wait for @felipepiovezan to take another look. https://github.com/llvm/llvm-project/pull/204788 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
