llvmorg-github-actions[bot] wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-lldb Author: Charles Zablit (charles-zablit) <details> <summary>Changes</summary> The client uses a 0x0 STDIO window size as a deliberate signal to the server that there is no client terminal, so the server should redirect the inferior's stdio over anonymous pipes instead of a ConPTY (on Windows). This is a follow up to https://github.com/llvm/llvm-project/pull/203562. rdar://178725958 --- Full diff: https://github.com/llvm/llvm-project/pull/205772.diff 1 Files Affected: - (modified) lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp (+1-1) ``````````diff diff --git a/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp b/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp index b5e0b8887f039..06a82eee621d3 100644 --- a/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp +++ b/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp @@ -2039,7 +2039,7 @@ int GDBRemoteCommunicationClient::SetSTDERR(const FileSpec &file_spec) { int GDBRemoteCommunicationClient::SetSTDIOWindowSize(uint16_t cols, uint16_t rows) { - if (cols == 0 || rows == 0) + if ((cols == 0) != (rows == 0)) return -1; StreamString packet; packet.Printf("QSetSTDIOWindowSize:cols=%u;rows=%u", `````````` </details> https://github.com/llvm/llvm-project/pull/205772 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
