================
@@ -226,16 +227,20 @@ ProcessLauncherWindows::LaunchProcess(const 
ProcessLaunchInfo &launch_info,
   // command line is not empty, its contents may be modified by CreateProcessW.
   WCHAR *pwcommandLine = wcommandLine.empty() ? nullptr : &wcommandLine[0];
 
-  std::wstring wexecutable, wworkingDirectory;
-  llvm::ConvertUTF8toWide(launch_info.GetExecutableFile().GetPath(),
----------------
charles-zablit wrote:

Before, we were only converting to a different encoding (`std::string` to 
`std::wstring` essentially).

Now, we are converting between windows path formats: DOS path to NT path. The 
first one is limited to 260 characters while the second is limited to 32,767. 
Most Windows APIs allow both.

Maybe it's worth adding some documentation to the `widenPath` method.

https://github.com/llvm/llvm-project/pull/206029
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to