https://github.com/charles-zablit created https://github.com/llvm/llvm-project/pull/206987
The third test in this file iterated `range(new_frame_count)` while the other two are bounded by `range(min(new_frame_count, 3))`. On Windows the deeper iteration hits llvm.org/pr24778 (CRT startup symbol resolution) and fails on the bottom frame's `assertNotEqual(pc, 0)`. This patch makes the test match the sibling tests' bound. the test still exercises the circular-dependency invariant on the top three frames. >From cd3818a1de13caf0011b294371da792f06375b71 Mon Sep 17 00:00:00 2001 From: Charles Zablit <[email protected]> Date: Wed, 1 Jul 2026 14:48:25 +0100 Subject: [PATCH] [lldb] Tighten TestFrameProviderCircularDependency loop --- .../circular_dependency/TestFrameProviderCircularDependency.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lldb/test/API/functionalities/scripted_frame_provider/circular_dependency/TestFrameProviderCircularDependency.py b/lldb/test/API/functionalities/scripted_frame_provider/circular_dependency/TestFrameProviderCircularDependency.py index 87a30c150e4e3..9f0f994458823 100644 --- a/lldb/test/API/functionalities/scripted_frame_provider/circular_dependency/TestFrameProviderCircularDependency.py +++ b/lldb/test/API/functionalities/scripted_frame_provider/circular_dependency/TestFrameProviderCircularDependency.py @@ -115,7 +115,7 @@ def test_circular_dependency_with_function_replacement(self): ) # Verify we can call methods on all frames (no circular dependency!). - for i in range(new_frame_count): + for i in range(min(new_frame_count, 3)): frame = thread.GetFrameAtIndex(i) self.assertIsNotNone(frame, f"Frame {i} should exist") # These calls should not trigger circular dependency. _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
