jimingham wrote:

So far as I can tell we don't have a programmatic way to say whether 
follows-fork is supported.  For sure, the Platform should say whether this 
system supports following forks.  And the test should be gated not on some 
static list of platforms but on querying this platform capability.

Once we know that, when you set this setting while there is a target, we really 
should ask its platform whether it supports it and warn then.  We can't always 
do that, in particular if this is set in the .lldbinit, we don't know what you 
are planning to target.   I'm not sure warning when you make a target that 
doesn't support this setting is helpful or would just get lost in the noise, 
however.

Part of the Platform's job in lldb is to know the capabilities of the platform. 
 We haven't exposed that yet in SBPlatform, so maybe we should think a bit 
about how to design this?  Do we want some kind of "capabilities object" or do 
we just want a bunch of API's like `SBPlatform::SupportsFollowFork()` etc.  So 
maybe cleaning this up should be a follow-on?

https://github.com/llvm/llvm-project/pull/208165
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to