[Lldb-commits] [PATCH] D36126: Fix incorrect use of std::unique

[Eugene Zemtsov via Phabricator via lldb-commits]

eugene created this revision.
eugene added a project: LLDB.

https://reviews.llvm.org/D36126

Files:
  source/Symbol/Symtab.cpp


Index: source/Symbol/Symtab.cpp
===================================================================
--- source/Symbol/Symtab.cpp
+++ source/Symbol/Symtab.cpp
@@ -616,8 +616,10 @@
   std::stable_sort(indexes.begin(), indexes.end(), comparator);
 
   // Remove any duplicates if requested
-  if (remove_duplicates)
-    std::unique(indexes.begin(), indexes.end());
+  if (remove_duplicates) {
+    auto last = std::unique(indexes.begin(), indexes.end());
+    indexes.erase(last, indexes.end());
+  }
 }
 
 uint32_t Symtab::AppendSymbolIndexesWithName(const ConstString &symbol_name,



Index: source/Symbol/Symtab.cpp
===================================================================
--- source/Symbol/Symtab.cpp
+++ source/Symbol/Symtab.cpp
@@ -616,8 +616,10 @@
   std::stable_sort(indexes.begin(), indexes.end(), comparator);
 
   // Remove any duplicates if requested
-  if (remove_duplicates)
-    std::unique(indexes.begin(), indexes.end());
+  if (remove_duplicates) {
+    auto last = std::unique(indexes.begin(), indexes.end());
+    indexes.erase(last, indexes.end());
+  }
 }
 
 uint32_t Symtab::AppendSymbolIndexesWithName(const ConstString &symbol_name,

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits