https://github.com/AaronBallman commented:
I think the test coverage is pretty light for adding a new builtin type. We should validate that it can round trip serialization correctly, add coverage for C as well, test mangling behavior (oops, probably need to update the demangler as well), etc. I'm not familiar enough with the SPIR-V spec to know what kinds of other things need to be handled though. I added @Keenuts and @VyacheslavLevytskyy as reviewers because they're backend SPIR-V folks, so they may have more ideas on the kinds of restrictions and corner cases we need to be considering in the frontend. https://github.com/llvm/llvm-project/pull/207077 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
