================
@@ -381,14 +381,14 @@ def parseOptionsAndInitTestdirs():
setting_list = setting[0].split("=", 1)
configuration.settings.append((setting_list[0], setting_list[1]))
- if args.d or args.attach_xcode:
+ if args.d or args.debug_with:
sys.stdout.write(
"Suspending the process %d to wait for debugger to attach...\n"
% os.getpid()
)
sys.stdout.flush()
- if args.attach_xcode:
+ if args.debug_with == "xcode":
----------------
jimingham wrote:
I missed that that would trigger a check. This is fine for now.
I don't think we want a static list of plugins. That would mean everybody who
had some custom way to attach would have to go through us. If we start do
something like have a defined place to look for these attach modules, the we'll
need some dynamic discovery routines. So if/when somebody does that, they can
just change this to:
```
add_argument(..., choices=[enumerate_attach_plugins()], ...)
```
So this seems a good way to start.
https://github.com/llvm/llvm-project/pull/209628
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
