llvmorg-github-actions[bot] wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-lldb Author: Raphael Isemann (Teemperor) <details> <summary>Changes</summary> `Stream::Printf` needs to call various other (variadic) functions, needs to parse the input string and potentially handle too-long format outputs. Calling in with a constant string is wasting a lot of instruction on doing nothing. assisted-by: claude --- Patch is 38.97 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/210290.diff 31 Files Affected: - (modified) lldb/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp (+2-2) - (modified) lldb/source/Plugins/ExpressionParser/Clang/ClangASTSource.cpp (+2-2) - (modified) lldb/source/Plugins/Instruction/ARM/EmulateInstructionARM.cpp (+8-8) - (modified) lldb/source/Plugins/Instruction/ARM/EmulationStateARM.cpp (+3-3) - (modified) lldb/source/Plugins/Language/CPlusPlus/BlockPointer.cpp (+1-1) - (modified) lldb/source/Plugins/Language/CPlusPlus/CxxStringTypes.cpp (+3-3) - (modified) lldb/source/Plugins/Language/CPlusPlus/LibCxxAtomic.cpp (+1-1) - (modified) lldb/source/Plugins/Language/CPlusPlus/LibCxxVariant.cpp (+1-1) - (modified) lldb/source/Plugins/Language/CPlusPlus/LibStdcpp.cpp (+2-2) - (modified) lldb/source/Plugins/Language/CPlusPlus/MsvcStlTree.cpp (+1-1) - (modified) lldb/source/Plugins/Language/CPlusPlus/MsvcStlVariant.cpp (+1-1) - (modified) lldb/source/Plugins/Language/ObjC/CF.cpp (+8-8) - (modified) lldb/source/Plugins/Language/ObjC/Cocoa.cpp (+11-11) - (modified) lldb/source/Plugins/Language/ObjC/CoreMedia.cpp (+3-3) - (modified) lldb/source/Plugins/Language/ObjC/NSException.cpp (+2-2) - (modified) lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp (+1-1) - (modified) lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCTypeEncodingParser.cpp (+2-2) - (modified) lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleThreadPlanStepThroughObjCTrampoline.cpp (+2-2) - (modified) lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp (+1-1) - (modified) lldb/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.cpp (+1-1) - (modified) lldb/source/Plugins/Platform/MacOSX/PlatformDarwinKernel.cpp (+6-6) - (modified) lldb/source/Plugins/Platform/POSIX/PlatformPOSIX.cpp (+4-4) - (modified) lldb/source/Plugins/Process/MacOSX-Kernel/CommunicationKDP.cpp (+1-1) - (modified) lldb/source/Plugins/Process/Utility/StopInfoMachException.cpp (+5-5) - (modified) lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp (+2-2) - (modified) lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp (+3-3) - (modified) lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp (+7-7) - (modified) lldb/source/Plugins/Process/minidump/ProcessMinidump.cpp (+6-6) - (modified) lldb/source/Plugins/Process/wasm/ProcessWasm.cpp (+3-3) - (modified) lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp (+3-3) - (modified) lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp (+8-8) ``````````diff diff --git a/lldb/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp b/lldb/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp index 7959a49fd03a1..90f0c041e386e 100644 --- a/lldb/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp +++ b/lldb/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp @@ -1415,7 +1415,7 @@ bool DynamicLoaderDarwinKernel::ParseKextSummaries( if (image_info.GetModule()) { unloaded_module_list.AppendIfNeeded(image_info.GetModule()); } - s->Printf("."); + s->PutCString("."); image_info.Clear(); // should pull it out of the KextImageInfos vector but that would // mutate the list and invalidate the to_be_removed bool vector; @@ -1427,7 +1427,7 @@ bool DynamicLoaderDarwinKernel::ParseKextSummaries( } if (load_kexts) { - s->Printf(" done.\n"); + s->PutCString(" done.\n"); if (kexts_failed_to_load.size() > 0 && number_of_new_kexts_being_added > 0) { s->Printf("Failed to load %d of %d kexts:\n", (int)kexts_failed_to_load.size(), diff --git a/lldb/source/Plugins/ExpressionParser/Clang/ClangASTSource.cpp b/lldb/source/Plugins/ExpressionParser/Clang/ClangASTSource.cpp index 8184a92b09aa1..511d15b209c44 100644 --- a/lldb/source/Plugins/ExpressionParser/Clang/ClangASTSource.cpp +++ b/lldb/source/Plugins/ExpressionParser/Clang/ClangASTSource.cpp @@ -898,9 +898,9 @@ void ClangASTSource::FindObjCMethodDecls(NameSearchContext &context) { StreamString ss; if (decl_name.isObjCZeroArgSelector()) { - ss.Printf("%s", decl_name.getAsString().c_str()); + ss.PutCString(decl_name.getAsString().c_str()); } else if (decl_name.isObjCOneArgSelector()) { - ss.Printf("%s", decl_name.getAsString().c_str()); + ss.PutCString(decl_name.getAsString().c_str()); } else { clang::Selector sel = decl_name.getObjCSelector(); diff --git a/lldb/source/Plugins/Instruction/ARM/EmulateInstructionARM.cpp b/lldb/source/Plugins/Instruction/ARM/EmulateInstructionARM.cpp index 6123a170fe7fb..4e412e5189469 100644 --- a/lldb/source/Plugins/Instruction/ARM/EmulateInstructionARM.cpp +++ b/lldb/source/Plugins/Instruction/ARM/EmulateInstructionARM.cpp @@ -14355,7 +14355,7 @@ EmulateInstructionARM::GetInstructionCondition() { bool EmulateInstructionARM::TestEmulation(Stream &out_stream, ArchSpec &arch, OptionValueDictionary *test_data) { if (!test_data) { - out_stream.Printf("TestEmulation: Missing test data.\n"); + out_stream.PutCString("TestEmulation: Missing test data.\n"); return false; } @@ -14368,7 +14368,7 @@ bool EmulateInstructionARM::TestEmulation(Stream &out_stream, ArchSpec &arch, uint32_t test_opcode; if ((value_sp.get() == nullptr) || (value_sp->GetType() != OptionValue::eTypeUInt64)) { - out_stream.Printf("TestEmulation: Error reading opcode from test file.\n"); + out_stream.PutCString("TestEmulation: Error reading opcode from test file.\n"); return false; } test_opcode = value_sp->GetValueAs<uint64_t>().value_or(0); @@ -14384,7 +14384,7 @@ bool EmulateInstructionARM::TestEmulation(Stream &out_stream, ArchSpec &arch, m_opcode_mode = eModeARM; m_opcode.SetOpcode32(test_opcode, endian::InlHostByteOrder()); } else { - out_stream.Printf("TestEmulation: Invalid arch.\n"); + out_stream.PutCString("TestEmulation: Invalid arch.\n"); return false; } @@ -14394,26 +14394,26 @@ bool EmulateInstructionARM::TestEmulation(Stream &out_stream, ArchSpec &arch, value_sp = test_data->GetValueForKey(before_key); if ((value_sp.get() == nullptr) || (value_sp->GetType() != OptionValue::eTypeDictionary)) { - out_stream.Printf("TestEmulation: Failed to find 'before' state.\n"); + out_stream.PutCString("TestEmulation: Failed to find 'before' state.\n"); return false; } OptionValueDictionary *state_dictionary = value_sp->GetAsDictionary(); if (!before_state.LoadStateFromDictionary(state_dictionary)) { - out_stream.Printf("TestEmulation: Failed loading 'before' state.\n"); + out_stream.PutCString("TestEmulation: Failed loading 'before' state.\n"); return false; } value_sp = test_data->GetValueForKey(after_key); if ((value_sp.get() == nullptr) || (value_sp->GetType() != OptionValue::eTypeDictionary)) { - out_stream.Printf("TestEmulation: Failed to find 'after' state.\n"); + out_stream.PutCString("TestEmulation: Failed to find 'after' state.\n"); return false; } state_dictionary = value_sp->GetAsDictionary(); if (!after_state.LoadStateFromDictionary(state_dictionary)) { - out_stream.Printf("TestEmulation: Failed loading 'after' state.\n"); + out_stream.PutCString("TestEmulation: Failed loading 'after' state.\n"); return false; } @@ -14425,7 +14425,7 @@ bool EmulateInstructionARM::TestEmulation(Stream &out_stream, ArchSpec &arch, bool success = EvaluateInstruction(eEmulateInstructionOptionAutoAdvancePC); if (!success) { - out_stream.Printf("TestEmulation: EvaluateInstruction() failed.\n"); + out_stream.PutCString("TestEmulation: EvaluateInstruction() failed.\n"); return false; } diff --git a/lldb/source/Plugins/Instruction/ARM/EmulationStateARM.cpp b/lldb/source/Plugins/Instruction/ARM/EmulationStateARM.cpp index 75dcb6ee6dcf6..1b4227080580b 100644 --- a/lldb/source/Plugins/Instruction/ARM/EmulationStateARM.cpp +++ b/lldb/source/Plugins/Instruction/ARM/EmulationStateARM.cpp @@ -245,11 +245,11 @@ bool EmulationStateARM::CompareState(EmulationStateARM &other_state, // other_state is the expected state. If it has memory, check it. if (!other_state.m_memory.empty() && m_memory != other_state.m_memory) { match = false; - out_stream.Printf("memory does not match\n"); - out_stream.Printf("got memory:\n"); + out_stream.PutCString("memory does not match\n"); + out_stream.PutCString("got memory:\n"); for (auto p : m_memory) out_stream.Printf("0x%08" PRIx64 ": 0x%08x\n", p.first, p.second); - out_stream.Printf("expected memory:\n"); + out_stream.PutCString("expected memory:\n"); for (auto p : other_state.m_memory) out_stream.Printf("0x%08" PRIx64 ": 0x%08x\n", p.first, p.second); } diff --git a/lldb/source/Plugins/Language/CPlusPlus/BlockPointer.cpp b/lldb/source/Plugins/Language/CPlusPlus/BlockPointer.cpp index 09368318b2db6..a88436bbbc67a 100644 --- a/lldb/source/Plugins/Language/CPlusPlus/BlockPointer.cpp +++ b/lldb/source/Plugins/Language/CPlusPlus/BlockPointer.cpp @@ -195,7 +195,7 @@ bool lldb_private::formatters::BlockPointerSummaryProvider( const char *child_value = qualified_child_representation_sp->GetValueAsCString(); - s.Printf("%s", child_value); + s.PutCString(child_value); return true; } diff --git a/lldb/source/Plugins/Language/CPlusPlus/CxxStringTypes.cpp b/lldb/source/Plugins/Language/CPlusPlus/CxxStringTypes.cpp index 1572921921002..6083386f97c0a 100644 --- a/lldb/source/Plugins/Language/CPlusPlus/CxxStringTypes.cpp +++ b/lldb/source/Plugins/Language/CPlusPlus/CxxStringTypes.cpp @@ -69,7 +69,7 @@ static bool CharStringSummaryProvider(ValueObject &valobj, Stream &stream) { } if (!StringPrinter::ReadStringAndDumpToStream<ElemType>(options)) - stream.Printf("Summary Unavailable"); + stream.PutCString("Summary Unavailable"); return true; } @@ -155,7 +155,7 @@ bool lldb_private::formatters::WCharStringSummaryProvider( return StringPrinter::ReadStringAndDumpToStream<StringElementType::UTF32>( options); default: - stream.Printf("size for wchar_t is not valid"); + stream.PutCString("size for wchar_t is not valid"); return true; } return true; @@ -210,7 +210,7 @@ bool lldb_private::formatters::WCharSummaryProvider( return StringPrinter::ReadBufferAndDumpToStream<StringElementType::UTF32>( options); default: - stream.Printf("size for wchar_t is not valid"); + stream.PutCString("size for wchar_t is not valid"); return true; } return true; diff --git a/lldb/source/Plugins/Language/CPlusPlus/LibCxxAtomic.cpp b/lldb/source/Plugins/Language/CPlusPlus/LibCxxAtomic.cpp index 97611a8dbde19..6ec9137e9e9c3 100644 --- a/lldb/source/Plugins/Language/CPlusPlus/LibCxxAtomic.cpp +++ b/lldb/source/Plugins/Language/CPlusPlus/LibCxxAtomic.cpp @@ -75,7 +75,7 @@ bool lldb_private::formatters::LibCxxAtomicSummaryProvider( std::string summary; if (atomic_value->GetSummaryAsCString(summary, options) && summary.size() > 0) { - stream.Printf("%s", summary.c_str()); + stream.PutCString(summary.c_str()); return true; } } diff --git a/lldb/source/Plugins/Language/CPlusPlus/LibCxxVariant.cpp b/lldb/source/Plugins/Language/CPlusPlus/LibCxxVariant.cpp index 9e56ef113b16a..6737110135c75 100644 --- a/lldb/source/Plugins/Language/CPlusPlus/LibCxxVariant.cpp +++ b/lldb/source/Plugins/Language/CPlusPlus/LibCxxVariant.cpp @@ -162,7 +162,7 @@ bool LibcxxVariantSummaryProvider(ValueObject &valobj, Stream &stream, return false; if (validity == LibcxxVariantIndexValidity::NPos) { - stream.Printf(" No Value"); + stream.PutCString(" No Value"); return true; } diff --git a/lldb/source/Plugins/Language/CPlusPlus/LibStdcpp.cpp b/lldb/source/Plugins/Language/CPlusPlus/LibStdcpp.cpp index aa3589f0ac113..b9d4e1105f3f9 100644 --- a/lldb/source/Plugins/Language/CPlusPlus/LibStdcpp.cpp +++ b/lldb/source/Plugins/Language/CPlusPlus/LibStdcpp.cpp @@ -480,7 +480,7 @@ bool formatters::LibStdcppVariantSummaryProvider( auto npos_value = LibStdcppVariantNposValue(*index_bytes_or_err); auto index = index_obj->GetValueAsUnsigned(0); if (index == npos_value) { - stream.Printf(" No Value"); + stream.PutCString(" No Value"); return true; } @@ -489,7 +489,7 @@ bool formatters::LibStdcppVariantSummaryProvider( if (!variant_type) return false; if (index >= variant_type.GetNumTemplateArguments(true)) { - stream.Printf(" <Invalid>"); + stream.PutCString(" <Invalid>"); return true; } diff --git a/lldb/source/Plugins/Language/CPlusPlus/MsvcStlTree.cpp b/lldb/source/Plugins/Language/CPlusPlus/MsvcStlTree.cpp index dce1887dd73ff..71fc7d4f03091 100644 --- a/lldb/source/Plugins/Language/CPlusPlus/MsvcStlTree.cpp +++ b/lldb/source/Plugins/Language/CPlusPlus/MsvcStlTree.cpp @@ -362,7 +362,7 @@ bool formatters::MsvcStlTreeIterSummaryProvider( MapEntry entry(node_sp.get()); if (entry.is_nil()) { - stream.Printf("end"); + stream.PutCString("end"); return true; } diff --git a/lldb/source/Plugins/Language/CPlusPlus/MsvcStlVariant.cpp b/lldb/source/Plugins/Language/CPlusPlus/MsvcStlVariant.cpp index 7b92e879036e6..86e270fce94d3 100644 --- a/lldb/source/Plugins/Language/CPlusPlus/MsvcStlVariant.cpp +++ b/lldb/source/Plugins/Language/CPlusPlus/MsvcStlVariant.cpp @@ -110,7 +110,7 @@ bool formatters::MsvcStlVariantSummaryProvider( return false; if (*index < 0) { - stream.Printf(" No Value"); + stream.PutCString(" No Value"); return true; } diff --git a/lldb/source/Plugins/Language/ObjC/CF.cpp b/lldb/source/Plugins/Language/ObjC/CF.cpp index 1efc15f8861a7..ad5f2c3f02862 100644 --- a/lldb/source/Plugins/Language/ObjC/CF.cpp +++ b/lldb/source/Plugins/Language/ObjC/CF.cpp @@ -186,35 +186,35 @@ bool lldb_private::formatters::CFBitVectorSummaryProvider( bool bit6 = (byte & 64) == 64; bool bit7 = (byte & 128) == 128; if (count) { - stream.Printf("%c", bit7 ? '1' : '0'); + stream.PutChar(bit7 ? '1' : '0'); count -= 1; } if (count) { - stream.Printf("%c", bit6 ? '1' : '0'); + stream.PutChar(bit6 ? '1' : '0'); count -= 1; } if (count) { - stream.Printf("%c", bit5 ? '1' : '0'); + stream.PutChar(bit5 ? '1' : '0'); count -= 1; } if (count) { - stream.Printf("%c", bit4 ? '1' : '0'); + stream.PutChar(bit4 ? '1' : '0'); count -= 1; } if (count) { - stream.Printf("%c", bit3 ? '1' : '0'); + stream.PutChar(bit3 ? '1' : '0'); count -= 1; } if (count) { - stream.Printf("%c", bit2 ? '1' : '0'); + stream.PutChar(bit2 ? '1' : '0'); count -= 1; } if (count) { - stream.Printf("%c", bit1 ? '1' : '0'); + stream.PutChar(bit1 ? '1' : '0'); count -= 1; } if (count) - stream.Printf("%c", bit0 ? '1' : '0'); + stream.PutChar(bit0 ? '1' : '0'); } return true; } diff --git a/lldb/source/Plugins/Language/ObjC/Cocoa.cpp b/lldb/source/Plugins/Language/ObjC/Cocoa.cpp index 39b027c9bda5c..a676f31b0740f 100644 --- a/lldb/source/Plugins/Language/ObjC/Cocoa.cpp +++ b/lldb/source/Plugins/Language/ObjC/Cocoa.cpp @@ -78,7 +78,7 @@ bool lldb_private::formatters::NSBundleSummaryProvider( bool was_nsstring_ok = NSStringSummaryProvider(*text, summary_stream, options); if (was_nsstring_ok && summary_stream.GetSize() > 0) { - stream.Printf("%s", summary_stream.GetData()); + stream.PutCString(summary_stream.GetData()); return true; } } @@ -127,7 +127,7 @@ bool lldb_private::formatters::NSTimeZoneSummaryProvider( bool was_nsstring_ok = NSStringSummaryProvider(*text, summary_stream, options); if (was_nsstring_ok && summary_stream.GetSize() > 0) { - stream.Printf("%s", summary_stream.GetData()); + stream.PutCString(summary_stream.GetData()); return true; } } @@ -176,7 +176,7 @@ bool lldb_private::formatters::NSNotificationSummaryProvider( bool was_nsstring_ok = NSStringSummaryProvider(*text, summary_stream, options); if (was_nsstring_ok && summary_stream.GetSize() > 0) { - stream.Printf("%s", summary_stream.GetData()); + stream.PutCString(summary_stream.GetData()); return true; } } @@ -754,12 +754,12 @@ bool lldb_private::formatters::NSDecimalNumberSummaryProvider( const bool is_nan = is_negative && (length == 0); if (is_nan) { - stream.Printf("NaN"); + stream.PutCString("NaN"); return true; } if (length == 0) { - stream.Printf("0"); + stream.PutCString("0"); return true; } @@ -769,7 +769,7 @@ bool lldb_private::formatters::NSDecimalNumberSummaryProvider( return false; if (is_negative) - stream.Printf("-"); + stream.PutCString("-"); stream.Printf("%" PRIu64 " x 10^%" PRIi8, mantissa, exponent); return true; @@ -972,7 +972,7 @@ bool lldb_private::formatters::NSDateSummaryProvider( // The relative time in seconds from Cocoa Epoch to [NSDate distantPast]. const double RelSecondsFromCocoaEpochToNSDateDistantPast = -63114076800; if (date_value == RelSecondsFromCocoaEpochToNSDateDistantPast) { - stream.Printf("0001-01-01 00:00:00 UTC"); + stream.PutCString("0001-01-01 00:00:00 UTC"); return true; } @@ -1026,7 +1026,7 @@ bool lldb_private::formatters::ObjCClassSummaryProvider( if (ConstString cs = Mangled(class_name).GetDemangledName()) class_name = cs; - stream.Printf("%s", class_name.AsCString("<unknown class>")); + stream.PutCString(class_name.AsCString("<unknown class>")); return true; } @@ -1143,10 +1143,10 @@ bool lldb_private::formatters::ObjCBOOLSummaryProvider( int8_t value = (real_guy_sp->GetValueAsSigned(0) & 0xFF); switch (value) { case 0: - stream.Printf("NO"); + stream.PutCString("NO"); break; case 1: - stream.Printf("YES"); + stream.PutCString("YES"); break; default: stream.Printf("%d", value); @@ -1217,7 +1217,7 @@ bool lldb_private::formatters::ObjCSELSummaryProvider( if (!valobj_sp) return false; - stream.Printf("%s", valobj_sp->GetSummaryAsCString()); + stream.PutCString(valobj_sp->GetSummaryAsCString()); return true; } diff --git a/lldb/source/Plugins/Language/ObjC/CoreMedia.cpp b/lldb/source/Plugins/Language/ObjC/CoreMedia.cpp index 1f4991bbfda28..a2e13adbb0f85 100644 --- a/lldb/source/Plugins/Language/ObjC/CoreMedia.cpp +++ b/lldb/source/Plugins/Language/ObjC/CoreMedia.cpp @@ -53,17 +53,17 @@ bool lldb_private::formatters::CMTimeSummaryProvider( const unsigned int FlagIndefinite = 16; if (flags.AnySet(FlagIndefinite)) { - stream.Printf("indefinite"); + stream.PutCString("indefinite"); return true; } if (flags.AnySet(FlagPositiveInf)) { - stream.Printf("+oo"); + stream.PutCString("+oo"); return true; } if (flags.AnySet(FlagNegativeInf)) { - stream.Printf("-oo"); + stream.PutCString("-oo"); return true; } diff --git a/lldb/source/Plugins/Language/ObjC/NSException.cpp b/lldb/source/Plugins/Language/ObjC/NSException.cpp index 5e9ee3346063c..8e0870f88d2e6 100644 --- a/lldb/source/Plugins/Language/ObjC/NSException.cpp +++ b/lldb/source/Plugins/Language/ObjC/NSException.cpp @@ -108,14 +108,14 @@ bool lldb_private::formatters::NSException_SummaryProvider( return false; if (!reason_sp) { - stream.Printf("No reason"); + stream.PutCString("No reason"); return false; } StreamString reason_str_summary; if (NSStringSummaryProvider(*reason_sp, reason_str_summary, options) && !reason_str_summary.Empty()) { - stream.Printf("%s", reason_str_summary.GetData()); + stream.PutCString(reason_str_summary.GetData()); return true; } else return false; diff --git a/lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp b/lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp index f1f71f7d7a451..9c905e50bffbb 100644 --- a/lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp +++ b/lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp @@ -1073,7 +1073,7 @@ class CommandObjectObjC_ClassTable_Dump : public CommandObjectParsed { std_out.Printf(" superclass = %s", superclass->GetClassName().AsCString("<unknown>")); } - std_out.Printf("\n"); + std_out.PutCString("\n"); if (m_options.m_verbose) { for (size_t i = 0; i < iterator->second->GetNumIVars(); i++) { auto ivar = iterator->second->GetIVarAtIndex(i); diff --git a/lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCTypeEncodingParser.cpp b/lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCTypeEncodingParser.cpp index c8fc1f235409c..4ce7a657e5559 100644 --- a/lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCTypeEncodingParser.cpp +++ b/lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCTypeEncodingParser.cpp @@ -45,7 +45,7 @@ AppleObjCTypeEncodingParser::AppleObjCTypeEncodingParser( std::string AppleObjCTypeEncodingParser::ReadStructName(llvm::StringRef &type) { StreamString buffer; while (!type.empty() && type.front() != '=') - buffer.Printf("%c", popChar(type)); + buffer.PutChar(popChar(type)); return std::string(buffer.GetString()); } @@ -57,7 +57,7 @@ AppleObjCTypeEncodingParser::ReadQuotedString(llvm::StringRef &type) { StreamString buffer; while (type.front() != '"') { - buffer.Printf("%c", popChar(type)); + buffer.PutChar(popChar(type)); if (type.empty()) return std::nullopt; diff --git a/lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleThreadPlanStepThroughObjCTrampoline.cpp b/lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleThreadPlanStepThroughObjCTrampoline.cpp index 5cc99ad12226e..2488d670766eb 100644 --- a/lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleThreadPlanStepThroughObjCTrampoline.cpp +++ b/lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleThreadPlanStepThroughObjCTrampoline.cpp @@ -88,7 +88,7 @@ bool AppleThreadPlanStepThroughObjCTrampoline:: void AppleThreadPlanStepThroughObjCTrampoline::GetDescription( Stream *s, lldb::DescriptionLevel level) { if (level == lldb::eDescriptionLevelBrief) - s->Printf("Step through ObjC trampoline"); + s->PutCString("Step through ObjC trampoline"); else { s->Printf("Stepping to implementation of ObjC method - obj: 0x%llx, isa: " "0x%" PRIx64 ", sel: 0x%" PRIx64, @@ -286,7 +286,7 @@ void AppleThreadPlanStepThroughDirectDis... [truncated] `````````` </details> https://github.com/llvm/llvm-project/pull/210290 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
