bulbazord wrote:

> I thought about having Module set the m_symfile_spec to the ObjectFile's 
> FileSpec at the same time it sets m_symfile_up

If it's possible for `GetSymbolFile` to point to the module's ObjectFile, then 
it makes sense to me that `m_symfile_spec` could be pointing at the module's 
ObjectFile FileSpec.

> but there are parts of code that are intentionally testing 
> GetSymbolFileFileSpec for its actual meaning, and I seem to be the only 
> person who has made this mistake so fixing it like this seems appropriate.

What do you mean by "actual meaning"? It's strange to me that `GetSymbolFile` 
can give you a valid answer and then `GetSymbolFileFileSpec` can give you 
something invalid. 

https://github.com/llvm/llvm-project/pull/210206
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to