llvmorg-github-actions[bot] wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-lldb Author: David Mentler (mentlerd) <details> <summary>Changes</summary> My test added in #<!-- -->209056 assumed that a `CXXSyntheticChildren` implementation for `std::vector` is readily available on all platforms, that is not the case. Do the safe thing and skip that part of the test if conditions are not right. --- Full diff: https://github.com/llvm/llvm-project/pull/210495.diff 1 Files Affected: - (modified) lldb/test/API/python_api/sbvalue_set_type_synthetic_override/TestSBValueSetTypeSyntheticOverride.py (+5-2) ``````````diff diff --git a/lldb/test/API/python_api/sbvalue_set_type_synthetic_override/TestSBValueSetTypeSyntheticOverride.py b/lldb/test/API/python_api/sbvalue_set_type_synthetic_override/TestSBValueSetTypeSyntheticOverride.py index e5e8f29ba0e75..907d1af956219 100644 --- a/lldb/test/API/python_api/sbvalue_set_type_synthetic_override/TestSBValueSetTypeSyntheticOverride.py +++ b/lldb/test/API/python_api/sbvalue_set_type_synthetic_override/TestSBValueSetTypeSyntheticOverride.py @@ -18,8 +18,11 @@ def test(self): # CXX runtime synthetic can be overridden vec = frame.FindVariable("vec") - self.assertTrue(vec.IsSynthetic()) - self.checkOverride(vec, before=None) + + # GNU libstdc++'s std::vector doesn't have a CXXSyntheticChildren implementation + # Use the fact that GetTypeSynthetic() only returns scripted SCPs to filter + if vec.IsSynthetic() and vec.GetTypeSynthetic() is None: + self.checkOverride(vec, before=None) # Python synthetic can be overridden foo = frame.FindVariable("foo") `````````` </details> https://github.com/llvm/llvm-project/pull/210495 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
