eugene accepted this revision. eugene added inline comments. This revision is now accepted and ready to land.
================ Comment at: source/Utility/Log.cpp:333 + +void Log::DisableLoggingChild() { + for (auto &c: *g_channel_map) ---------------- A little comment here describing nature of a deadlock if we don't disable logging would be nice. https://reviews.llvm.org/D38938 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits