clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
See inline comments.
================
Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:2050-2052
+ if (dwarf_cu->ExtractDIEsIfNeeded(DWARFCompileUnit::
+ ExtractDIEsIfNeededKind::AllDiesButCuDieOnlyForPartialUnits) > 1)
clear_cu_dies[cu_idx] = true;
----------------
All of these changes can be avoided by just appropriately checking for partial
units and skipping them in this index function. Do you plan on using this
functionality in any other place? I would rather you just fix this function to
filter out the partial units.
https://reviews.llvm.org/D40471
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
