fjricci added inline comments.

================
Comment at: source/Host/common/TaskPool.cpp:55
+  static const unsigned g_hardware_concurrency = 
+    std::max(1u, std::thread::hardware_concurrency());
+  return g_hardware_concurrency;
----------------
Is 1 the best default here when hardware_concurrency() isn't computable? Seems 
like it could have some big performance implications, and I'm not sure how 
common it is for people to debug on host machines that only support one thread.


Repository:
  rL LLVM

https://reviews.llvm.org/D40587



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
  • [Lldb-commits] [PA... Alexander Shaposhnikov via Phabricator via lldb-commits
    • [Lldb-commits... Alexander Shaposhnikov via Phabricator via lldb-commits
    • [Lldb-commits... Pavel Labath via Phabricator via lldb-commits
    • [Lldb-commits... Francis Ricci via Phabricator via lldb-commits
    • [Lldb-commits... Alexander Shaposhnikov via Phabricator via lldb-commits

Reply via email to