tatyana-krasnukha added a comment.

There is the function GetDisasmToUse in InstructionLLVMC class that can return 
nullptr. But this case is not handled in any usage. I suppose that caller 
functions cannot be invoked if !DisassemblerLLVMC::IsValid(). But it still 
looks dangerous for me. May be GetDisasmToUse should assert if neither 
m_disasm_up nor m_alternate_disasm_up exists?  And may return a reference then.


https://reviews.llvm.org/D41584



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to