tberghammer accepted this revision. tberghammer added a comment. Thank you for looking into this. The change looks good on Linux with both normal-dwarf, split-dwarf and mixed-dwarf (as well as with dwp) but can you (or somebody from Apple) please make sure it doesn't break MachO and/or dSym (I don't expect any issue but I know little about that implementation)?
================ Comment at: packages/Python/lldbsuite/test/linux/mix-dwo-and-regular-objects/Makefile:4 +C_SOURCES := a.c b.c +CFLAGS_EXTRAS += -g -O0 + ---------------- I think these flags are specified by default in Makefile.rules ================ Comment at: packages/Python/lldbsuite/test/linux/mix-dwo-and-regular-objects/Makefile:10-12 +.PHONY: clean +clean:: + $(RM) -f a.dwo a.o b.o main ---------------- Do you need this? I think Makefile.rules should generate it for you and looking at that rule it should be correct. Repository: rL LLVM https://reviews.llvm.org/D42563 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
