clayborg added a comment.

In https://reviews.llvm.org/D42145#994556, @labath wrote:

> I think we're slowly getting there, but we could cleanup the implementation a 
> bit.
>
> I  am also not sure that the `WriteObjectFile` name really captures what this 
> function does, but I don't have a suggestion for a better name either....


Looking at the API I wouldn't immediately assume that WriteObjectFile would be 
flash aware and WriteMemory wouldn't... How about we add a new parameter to 
Process::WriteMemory that like "bool write_flash". It can default to false. 
Then if this is true, then we do the extra legwork to try and figure out the 
memory map. If false, just write the memory.


https://reviews.llvm.org/D42145



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to