labath added a comment. The change seems fine to me, and I don't really have anything to add to the things that were said already.
Testing the completion of things that require a target/module/etc. will be a bit tricky, but that's something we should figure out anyway to have more targeted completion tests. https://reviews.llvm.org/D43048 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
