That looks reasonable, since this is a class method, yes. Thanks for spotting it! Would you mind committing the change?
-- adrian > On Feb 28, 2018, at 6:46 PM, Vedant Kumar <v...@apple.com> wrote: > > Hey Adrian, > > Did you mean to write cls.getBuildArtifact() here? > > I'm seeing a Python exception locally when I run check-lldb-single: > > Traceback (most recent call last): > File "/Users/vsk/src/llvm.org > <http://llvm.org/>-lldbsan/llvm/tools/lldb/packages/Python/lldbsuite/test/lldbtest.py", > line 584, in tearDownClass > cls.classCleanup() > File "/Users/vsk/src/llvm.org > <http://llvm.org/>-lldbsan/llvm/tools/lldb/packages/Python/lldbsuite/test/settings/quoting/TestQuoting.py", > line 25, in classCleanup > cls.RemoveTempFile(self.getBuildArtifact("stdout.txt")) > NameError: global name 'self' is not defined > > vedant > >> On Jan 30, 2018, at 10:29 AM, Adrian Prantl via lldb-commits >> <lldb-commits@lists.llvm.org <mailto:lldb-commits@lists.llvm.org>> wrote: >> >> ============================================================================== >> --- >> lldb/trunk/packages/Python/lldbsuite/test/settings/quoting/TestQuoting.py >> (original) >> +++ >> lldb/trunk/packages/Python/lldbsuite/test/settings/quoting/TestQuoting.py >> Tue Jan 30 10:29:16 2018 >> @@ -22,7 +22,7 @@ class SettingsCommandTestCase(TestBase): >> @classmethod >> def classCleanup(cls): >> """Cleanup the test byproducts.""" >> - cls.RemoveTempFile("stdout.txt") >> + cls.RemoveTempFile(self.getBuildArtifact("stdout.txt")) >
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
