labath added a comment.

Ah, sorry. I didn't get where you were going with your previous comment. The 
ObjectFile->Process dependency is something that I think we shouldn't have, but 
whether it's in an header or implementation file makes little difference to me. 
So I think moving the #include is fine.

otoh, since we wen't down the path of having a separate 
Process::WriteObjectFile method, and the only usage of WriteEntry is there, I 
can see a case for moving this struct declaration into the ObjectFile class and 
avoiding this issue altogether.


https://reviews.llvm.org/D42145



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to