labath added a reviewer: davide. labath added a comment. I think the most controversial issue here is the testing... davide may have some thoughts on that.
================ Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:4529 +SymbolFileDWARF::DWZCommonFile::DWZCommonFile( + std::unique_ptr<SymbolFileDWARF> &&symbol_file, + lldb::ObjectFileSP &&obj_file, lldb::ModuleSP &&module) ---------------- the references are superfluous here (this just caught my eye because it's at the bottom of the patch). https://reviews.llvm.org/D40474 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
