labath added a comment.

I wonder if we shouldn't just fix the TestDisassembleBreakpoint to not require 
adding every single architecture. That test was added because lldb-server was 
not removing the traps from the memory read packets. This is something that is 
completely independent of us later trying to disassemble the memory we got 
back. To test that, it should be sufficient to compare the memory contents 
before and after setting a breakpoint.

Guessing what instructions will the compiler emit for a particular piece of C 
will just make the test fragile...



================
Comment at: packages/Python/lldbsuite/test/make/Makefile.rules:189
        endif
+       ifeq "$(ARCH)" "ppc64le"
+               override ARCH := $(subst ppc64le,64,$(ARCH))
----------------
Why do you need both powerpc64le and ppc64le?


https://reviews.llvm.org/D44472



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
  • [Lldb-commits] ... Pavel Labath via Phabricator via lldb-commits
    • [Lldb-comm... Alexandre Yukio Yamashita via Phabricator via lldb-commits
    • [Lldb-comm... Alexandre Yukio Yamashita via Phabricator via lldb-commits
    • [Lldb-comm... Pavel Labath via Phabricator via lldb-commits
    • [Lldb-comm... Alexandre Yukio Yamashita via Phabricator via lldb-commits
    • [Lldb-comm... Alexandre Yukio Yamashita via Phabricator via lldb-commits
      • Re: [L... Davide Italiano via lldb-commits
        • [L... Davide Italiano via Phabricator via lldb-commits
    • [Lldb-comm... Leonardo Bianconi via Phabricator via lldb-commits
    • [Lldb-comm... Davide Italiano via Phabricator via lldb-commits
    • [Lldb-comm... Davide Italiano via Phabricator via lldb-commits

Reply via email to