On Fri, Apr 6, 2018 at 1:02 AM, Jan Kratochvil via Phabricator <revi...@reviews.llvm.org> wrote: > jankratochvil added a comment. > > I disagree with this patch as `DWARFUnit` was a lightweight wrapper for > `DWARFPartialUnit`. Now I will have to create some new lightweight > superclass like `DWARFAbstractUnit`. > My patch prepared it for: > > DWARFUnit->DWARFCompileUnit > DWARFUnit->DWARFPartialUnit > > And I planned the type units should be implemented like: > > DWARFUnit->DWARFSomeNameUnit->DWARFCompileUnit > DWARFUnit->DWARFSomeNameUnit->DWARFTypeUnit > DWARFUnit->DWARFPartialUnit > > This patch just reused + changed my abstraction for a completely different > purpose and I will have to reimplement it again under a different name. Or > what do you suggest? >
As there's some disagreement on how to proceed forward, we can probably revert this for now and start a discussion. You can probably do it yourself. -- Davide _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
