jingham added a comment.

Except for a minor comment, this seems fine to me, and is a useful addition!



================
Comment at: packages/Python/lldbsuite/test/lldbutil.py:579
         test.assertTrue(
-            file_name == out_file_name,
+            out_file_name in file_name,
             "Breakpoint file name '%s' doesn't match resultant name '%s'." %
----------------
The output file name should always END with the original file name, right?  Can 
we make this check reflect that more closely?


https://reviews.llvm.org/D45592



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to