clayborg added a comment.

In https://reviews.llvm.org/D45554#1066730, @eugene wrote:

> There is an ownership cycle between BreakpointSite::m_owners and 
> BreakpointLocation::m_bp_site_sp.
>  We should probably make m_owners a collection of weak references. 
>  But currently most of the code just works it around by calling 
> Breakpoint::ClearAllBreakpointSites() before deleting a breakpoint.


Anytime there is a clear hierarchy we should use shared and weak pointers 
correctly. I would vote to fix this issue.


https://reviews.llvm.org/D45554



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to