davide@Davidinos-Mac-Pro ~/w/l/llvm-project-20170507> git llvm push Pushing 1 commit: deaca6ae380 Revert "[debugserver] Remove dead function call. NFCI."
On Fri, Apr 13, 2018 at 2:21 PM, Davide Italiano <dccitali...@gmail.com> wrote: > Oops. Sorry. Fixing this now. > > On Fri, Apr 13, 2018 at 1:55 PM, Frédéric Riss via lldb-commits > <lldb-commits@lists.llvm.org> wrote: >> >> >>> On Apr 13, 2018, at 1:47 PM, Davide Italiano via lldb-commits >>> <lldb-commits@lists.llvm.org> wrote: >>> >>> Author: davide >>> Date: Fri Apr 13 13:47:25 2018 >>> New Revision: 330066 >>> >>> URL: http://llvm.org/viewvc/llvm-project?rev=330066&view=rev >>> Log: >>> [debugserver] Remove dead function call. NFCI. >>> >>> Modified: >>> lldb/trunk/tools/debugserver/source/RNBRemote.cpp >>> >>> Modified: lldb/trunk/tools/debugserver/source/RNBRemote.cpp >>> URL: >>> http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/debugserver/source/RNBRemote.cpp?rev=330066&r1=330065&r2=330066&view=diff >>> ============================================================================== >>> --- lldb/trunk/tools/debugserver/source/RNBRemote.cpp (original) >>> +++ lldb/trunk/tools/debugserver/source/RNBRemote.cpp Fri Apr 13 13:47:25 >>> 2018 >>> @@ -6089,9 +6089,6 @@ rnb_err_t RNBRemote::HandlePacket_qProce >>> ((addr_size == 8) ? sizeof(mach_header_64) : sizeof(mach_header)); >>> load_command lc; >>> for (uint32_t i = 0; i < mh.ncmds && !os_handled; ++i) { >>> - const nub_size_t bytes_read = >>> - DNBProcessMemoryRead(pid, load_command_addr, sizeof(lc), &lc); >>> - >>> uint32_t major_version, minor_version, patch_version; >>> auto *platform = DNBGetDeploymentInfo(pid, lc, load_command_addr, >>> major_version, minor_version, >> >> This is not dead, it fills in lc which is used on the next line. I doubt >> this passes tests if you use the built debug server. The return value is >> unused though. >> _______________________________________________ >> lldb-commits mailing list >> lldb-commits@lists.llvm.org >> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits