alur added inline comments.
================ Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:1893 sect_type = eSectionTypeDWARFDebugAbbrev; - else if (name == g_sect_name_dwarf_debug_addr) + else if (name == g_sect_name_dwarf_debug_addr || + name == g_sect_name_dwarf_zdebug_addr) ---------------- aprantl wrote: > Could this entire device be replaced by a llvm::StringSwitch or something > else more elegant? I moved it out into a separate method with a StringSwitch ================ Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:3451 + if (!llvm::object::Decompressor::isCompressedELFSection( + section->Get(), section->GetName().GetStringRef())) return ObjectFile::ReadSectionData(section, section_offset, dst, dst_len); ---------------- clayborg wrote: > use "section_name" here instead of "section->GetName().GetStringRef()" since > we switched it to a StringRef This is a separate method, which doesn't have a section_name variable. ================ Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:3472 + section->Get(), section->GetName().GetStringRef())) return result; ---------------- clayborg wrote: > Ditto Same here. https://reviews.llvm.org/D45628 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits