labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
looks good. I don't know if anyone else has an opinion on how should we treat
"" for mapping purposes, but treating it as "." seems fine to me.
================
Comment at: unittests/Utility/FileSpecTest.cpp:300
+ for (const auto &path: not_relative) {
+ FileSpec spec(path, false, FileSpec::Style::posix);
+ EXPECT_FALSE(spec.IsRelative());
----------------
In tests like these, it's good to add something like `SCOPED_TRACE(path)` or
similar. That way, when a test fails you will see which path caused the failure
instead of just a generic "spec.IsRelative() is true" message.
https://reviews.llvm.org/D47021
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
