clayborg added inline comments.
================ Comment at: source/API/CMakeLists.txt:184 + set(EXECUTABLE_NAME "LLDB") + set(CURRENT_PROJECT_VERSION "360.99.0") set_target_properties(liblldb PROPERTIES ---------------- Currently the apple generic versioning is used and the value for this is grabbed from CURRENT_PROJECT_VERSION in the Xcode project in lldb.xcodeproj/project.pbxproj. We will need to let people know that they will need to update this variable from now on. ================ Comment at: source/API/CMakeLists.txt:184 + set(EXECUTABLE_NAME "LLDB") + set(CURRENT_PROJECT_VERSION "360.99.0") set_target_properties(liblldb PROPERTIES ---------------- sas wrote: > clayborg wrote: > > Currently the apple generic versioning is used and the value for this is > > grabbed from CURRENT_PROJECT_VERSION in the Xcode project in > > lldb.xcodeproj/project.pbxproj. We will need to let people know that they > > will need to update this variable from now on. > Hardcoding this here isn't ideal. Where did you get this number from? Is > there a way to fetch it from a single location? It was hardcoded into the Xcode project before. The numbers would be manually bumped by using "agvtool bump -all". That would update the Xcode project and a few plist files. Feel free to try running that from the root LLDB directory to see all files that get updated, then revert once you see what changed. https://reviews.llvm.org/D47792 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
