[Lldb-commits] [PATCH] D47992: [lldb-mi] Clean up and update a few MI commands.

[Greg Clayton via Phabricator via lldb-commits]

clayborg added inline comments.


================
Comment at: tools/lldb-mi/MICmdCmdExec.cpp:139
+      const CMIUtilString 
&rErrMsg(CMIDriver::Instance().GetErrorDescription());
+      this->SetError(CMIUtilString::Format(
+          MIRSRC(IDS_CMD_ERR_SET_NEW_DRIVER_STATE),
----------------
any reason for the "this->"? Remove it?


================
Comment at: tools/lldb-mi/MICmdCmdExec.cpp:141
+          MIRSRC(IDS_CMD_ERR_SET_NEW_DRIVER_STATE),
+          this->m_cmdData.strMiCmd.c_str(),
+          rErrMsg.c_str()));
----------------
any reason for the "this->"? Remove it?


================
Comment at: tools/lldb-mi/MICmdCmdExec.cpp:244
       const CMIUtilString 
&rErrMsg(CMIDriver::Instance().GetErrorDescription());
-      SetError(CMIUtilString::Format(MIRSRC(IDS_CMD_ERR_SET_NEW_DRIVER_STATE),
-                                     m_cmdData.strMiCmd.c_str(),
-                                     rErrMsg.c_str()));
+      this->SetError(CMIUtilString::Format(
+          MIRSRC(IDS_CMD_ERR_SET_NEW_DRIVER_STATE),
----------------
any reason for the "this->"? Remove it?


================
Comment at: tools/lldb-mi/MICmdCmdExec.cpp:246
+          MIRSRC(IDS_CMD_ERR_SET_NEW_DRIVER_STATE),
+          this->m_cmdData.strMiCmd.c_str(),
+          rErrMsg.c_str()));
----------------
any reason for the "this->"? Remove it?


https://reviews.llvm.org/D47992



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits