labath accepted this revision.
labath added a comment.

Sorry for the slow response, I am OOO officially :P.

I think this is fine in general. As for the list of platforms, android should 
be on that list but not for long (which is why one of the things I was planning 
to do next week was to implement something like this). I am not sure about 
NetBSD, but @krytarowski should be able to add that easily if that is the case.

For the category markup, I was hoping you would just place a `.categories` file 
in the appropriate subfolder, but after checking I see that this is actually 
consistent with how libc++ tests are marked up, so that is not a big deal 
either. I'll probably convert both of them to the filesystem-based markup next 
week.


https://reviews.llvm.org/D49110



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to