I've reverted this to keep the bots green until the issues pointed out by Stella and Raphael are resolved.
Based on a quick inspection, it seems that the test issue is that `GetSystemInfo` call that has been added to MinidumpParser::Initialize is failing. I guess that's because the hand-crafted(?) minidumps for these tests don't contain the necessary data. For the -Wextended-offsetof issue, the way that other register contexts avoid those is by factoring this out into two offsetof expressions (offsetof(big_struct, small_struct_field) + offsetof(small_struct, actual_field)). On Fri, 3 Aug 2018 at 07:28, Raphael Isemann via Phabricator <revi...@reviews.llvm.org> wrote: > > teemperor added a comment. > > I don't see this mentioned here yet, so: This patch also seems to introduce a > few hundred warnings with -Wextended-offsetof (which is enabled by default on > the macOS builds): > > > [...]llvm/tools/lldb/source/Plugins/Process/minidump/RegisterContextMinidump_ARM64.cpp:510:5: > warning: using extended field designator is an extension > [-Wextended-offsetof] > DEF_S(20), > ^~~~~~~~~ > > [...]llvm/tools/lldb/source/Plugins/Process/minidump/RegisterContextMinidump_ARM64.cpp:67:25: > note: expanded from macro 'DEF_S' > "s" #i, nullptr, 4, OFFSET(v[i * 16]), eEncodingVector, > \ > ^~~~~~~~~~~~~~~~~ > > [...]llvm/tools/lldb/source/Plugins/Process/minidump/RegisterContextMinidump_ARM64.cpp:29:20: > note: expanded from macro 'OFFSET' > #define OFFSET(r) (offsetof(RegisterContextMinidump_ARM64::Context, r)) > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > [...]stddef.h:120:24: note: expanded from macro 'offsetof' > #define offsetof(t, d) __builtin_offsetof(t, d) > ^ ~ > > (And the tests also fail on macOS, but they are probably fixed when the > Linux/Windows tests are fixed). > > > Repository: > rL LLVM > > https://reviews.llvm.org/D49750 > > > _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits