Author: labath Date: Wed Nov 14 06:58:36 2018 New Revision: 346867 URL: http://llvm.org/viewvc/llvm-project?rev=346867&view=rev Log: Move DataExtractorTest to unittests/Utility
The DataExtractor class itself was moved to Utility some time ago, but it seems this was not reflected in the location of the test code. Fix that. Added: lldb/trunk/unittests/Utility/DataExtractorTest.cpp - copied, changed from r346853, lldb/trunk/unittests/Core/DataExtractorTest.cpp Removed: lldb/trunk/unittests/Core/DataExtractorTest.cpp Modified: lldb/trunk/unittests/Core/CMakeLists.txt lldb/trunk/unittests/Utility/CMakeLists.txt Modified: lldb/trunk/unittests/Core/CMakeLists.txt URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/unittests/Core/CMakeLists.txt?rev=346867&r1=346866&r2=346867&view=diff ============================================================================== --- lldb/trunk/unittests/Core/CMakeLists.txt (original) +++ lldb/trunk/unittests/Core/CMakeLists.txt Wed Nov 14 06:58:36 2018 @@ -1,6 +1,5 @@ add_lldb_unittest(LLDBCoreTests BroadcasterTest.cpp - DataExtractorTest.cpp EventTest.cpp ListenerTest.cpp MangledTest.cpp Removed: lldb/trunk/unittests/Core/DataExtractorTest.cpp URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/unittests/Core/DataExtractorTest.cpp?rev=346866&view=auto ============================================================================== --- lldb/trunk/unittests/Core/DataExtractorTest.cpp (original) +++ lldb/trunk/unittests/Core/DataExtractorTest.cpp (removed) @@ -1,168 +0,0 @@ -//===-- DataExtractorTest.cpp -----------------------------------*- C++ -*-===// -// -// The LLVM Compiler Infrastructure -// -// This file is distributed under the University of Illinois Open Source -// License. See LICENSE.TXT for details. -// -//===----------------------------------------------------------------------===// - -#include "gtest/gtest.h" - -#include "lldb/Utility/DataExtractor.h" - -using namespace lldb_private; - -TEST(DataExtractorTest, GetBitfield) { - uint8_t buffer[] = {0x01, 0x23, 0x45, 0x67}; - DataExtractor LE(buffer, sizeof(buffer), lldb::eByteOrderLittle, - sizeof(void *)); - DataExtractor BE(buffer, sizeof(buffer), lldb::eByteOrderBig, sizeof(void *)); - - lldb::offset_t offset; - - offset = 0; - ASSERT_EQ(buffer[1], LE.GetMaxU64Bitfield(&offset, sizeof(buffer), 8, 8)); - offset = 0; - ASSERT_EQ(buffer[1], BE.GetMaxU64Bitfield(&offset, sizeof(buffer), 8, 8)); - - offset = 0; - ASSERT_EQ(int8_t(buffer[1]), - LE.GetMaxS64Bitfield(&offset, sizeof(buffer), 8, 8)); - offset = 0; - ASSERT_EQ(int8_t(buffer[1]), - BE.GetMaxS64Bitfield(&offset, sizeof(buffer), 8, 8)); -} - -TEST(DataExtractorTest, PeekData) { - uint8_t buffer[] = {0x01, 0x02, 0x03, 0x04}; - DataExtractor E(buffer, sizeof buffer, lldb::eByteOrderLittle, 4); - - EXPECT_EQ(buffer + 0, E.PeekData(0, 0)); - EXPECT_EQ(buffer + 0, E.PeekData(0, 4)); - EXPECT_EQ(nullptr, E.PeekData(0, 5)); - - EXPECT_EQ(buffer + 2, E.PeekData(2, 0)); - EXPECT_EQ(buffer + 2, E.PeekData(2, 2)); - EXPECT_EQ(nullptr, E.PeekData(2, 3)); - - EXPECT_EQ(buffer + 4, E.PeekData(4, 0)); - EXPECT_EQ(nullptr, E.PeekData(4, 1)); -} - -TEST(DataExtractorTest, GetMaxU64) { - uint8_t buffer[] = {0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07, 0x08}; - DataExtractor LE(buffer, sizeof(buffer), lldb::eByteOrderLittle, - sizeof(void *)); - DataExtractor BE(buffer, sizeof(buffer), lldb::eByteOrderBig, sizeof(void *)); - - lldb::offset_t offset; - - // Check with the minimum allowed byte size. - offset = 0; - EXPECT_EQ(0x01U, LE.GetMaxU64(&offset, 1)); - EXPECT_EQ(1U, offset); - offset = 0; - EXPECT_EQ(0x01U, BE.GetMaxU64(&offset, 1)); - EXPECT_EQ(1U, offset); - - // Check with a non-zero offset. - offset = 1; - EXPECT_EQ(0x0302U, LE.GetMaxU64(&offset, 2)); - EXPECT_EQ(3U, offset); - offset = 1; - EXPECT_EQ(0x0203U, BE.GetMaxU64(&offset, 2)); - EXPECT_EQ(3U, offset); - - // Check with the byte size not being a multiple of 2. - offset = 0; - EXPECT_EQ(0x07060504030201U, LE.GetMaxU64(&offset, 7)); - EXPECT_EQ(7U, offset); - offset = 0; - EXPECT_EQ(0x01020304050607U, BE.GetMaxU64(&offset, 7)); - EXPECT_EQ(7U, offset); - - // Check with the maximum allowed byte size. - offset = 0; - EXPECT_EQ(0x0807060504030201U, LE.GetMaxU64(&offset, 8)); - EXPECT_EQ(8U, offset); - offset = 0; - EXPECT_EQ(0x0102030405060708U, BE.GetMaxU64(&offset, 8)); - EXPECT_EQ(8U, offset); -} - -TEST(DataExtractorTest, GetMaxS64) { - uint8_t buffer[] = {0x01, 0x02, 0x83, 0x04, 0x05, 0x06, 0x07, 0x08}; - DataExtractor LE(buffer, sizeof(buffer), lldb::eByteOrderLittle, - sizeof(void *)); - DataExtractor BE(buffer, sizeof(buffer), lldb::eByteOrderBig, sizeof(void *)); - - lldb::offset_t offset; - - // Check with the minimum allowed byte size. - offset = 0; - EXPECT_EQ(0x01, LE.GetMaxS64(&offset, 1)); - EXPECT_EQ(1U, offset); - offset = 0; - EXPECT_EQ(0x01, BE.GetMaxS64(&offset, 1)); - EXPECT_EQ(1U, offset); - - // Check that sign extension works correctly. - offset = 0; - int64_t value = LE.GetMaxS64(&offset, 3); - EXPECT_EQ(0xffffffffff830201U, *reinterpret_cast<uint64_t *>(&value)); - EXPECT_EQ(3U, offset); - offset = 2; - value = BE.GetMaxS64(&offset, 3); - EXPECT_EQ(0xffffffffff830405U, *reinterpret_cast<uint64_t *>(&value)); - EXPECT_EQ(5U, offset); - - // Check with the maximum allowed byte size. - offset = 0; - EXPECT_EQ(0x0807060504830201, LE.GetMaxS64(&offset, 8)); - EXPECT_EQ(8U, offset); - offset = 0; - EXPECT_EQ(0x0102830405060708, BE.GetMaxS64(&offset, 8)); - EXPECT_EQ(8U, offset); -} - -TEST(DataExtractorTest, GetMaxU64_unchecked) { - uint8_t buffer[] = {0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07, 0x08}; - DataExtractor LE(buffer, sizeof(buffer), lldb::eByteOrderLittle, - sizeof(void *)); - DataExtractor BE(buffer, sizeof(buffer), lldb::eByteOrderBig, sizeof(void *)); - - lldb::offset_t offset; - - // Check with the minimum allowed byte size. - offset = 0; - EXPECT_EQ(0x01U, LE.GetMaxU64_unchecked(&offset, 1)); - EXPECT_EQ(1U, offset); - offset = 0; - EXPECT_EQ(0x01U, BE.GetMaxU64_unchecked(&offset, 1)); - EXPECT_EQ(1U, offset); - - // Check with a non-zero offset. - offset = 1; - EXPECT_EQ(0x0302U, LE.GetMaxU64_unchecked(&offset, 2)); - EXPECT_EQ(3U, offset); - offset = 1; - EXPECT_EQ(0x0203U, BE.GetMaxU64_unchecked(&offset, 2)); - EXPECT_EQ(3U, offset); - - // Check with the byte size not being a multiple of 2. - offset = 0; - EXPECT_EQ(0x07060504030201U, LE.GetMaxU64_unchecked(&offset, 7)); - EXPECT_EQ(7U, offset); - offset = 0; - EXPECT_EQ(0x01020304050607U, BE.GetMaxU64_unchecked(&offset, 7)); - EXPECT_EQ(7U, offset); - - // Check with the maximum allowed byte size. - offset = 0; - EXPECT_EQ(0x0807060504030201U, LE.GetMaxU64_unchecked(&offset, 8)); - EXPECT_EQ(8U, offset); - offset = 0; - EXPECT_EQ(0x0102030405060708U, BE.GetMaxU64_unchecked(&offset, 8)); - EXPECT_EQ(8U, offset); -} Modified: lldb/trunk/unittests/Utility/CMakeLists.txt URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/unittests/Utility/CMakeLists.txt?rev=346867&r1=346866&r2=346867&view=diff ============================================================================== --- lldb/trunk/unittests/Utility/CMakeLists.txt (original) +++ lldb/trunk/unittests/Utility/CMakeLists.txt Wed Nov 14 06:58:36 2018 @@ -6,6 +6,7 @@ add_lldb_unittest(UtilityTests CleanUpTest.cpp ConstStringTest.cpp CompletionRequestTest.cpp + DataExtractorTest.cpp EnvironmentTest.cpp FileSpecTest.cpp FlagsTest.cpp Copied: lldb/trunk/unittests/Utility/DataExtractorTest.cpp (from r346853, lldb/trunk/unittests/Core/DataExtractorTest.cpp) URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/unittests/Utility/DataExtractorTest.cpp?p2=lldb/trunk/unittests/Utility/DataExtractorTest.cpp&p1=lldb/trunk/unittests/Core/DataExtractorTest.cpp&r1=346853&r2=346867&rev=346867&view=diff ============================================================================== (empty) _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits