clayborg accepted this revision. clayborg added inline comments. This revision is now accepted and ready to land.
================ Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:355-356 + if (addr_base == LLDB_INVALID_ADDRESS) + addr_base = cu_die.GetAttributeValueAsUnsigned(m_dwarf, this, + DW_AT_GNU_addr_base, 0); dwo_cu->SetAddrBase(addr_base); ---------------- grimar wrote: > clayborg wrote: > > Do we still want the addr_base to default to zero instead of > > LLDB_INVALID_ADDRESS here? > I believe so. Setting the addr_base to default zero looks fine to me. That > way the existent code does not > need to check for LLDB_INVALID_ADDRESS and can just call the `GetAddrBase` > and add the result > to the offset calculation. > That is how things already work and I do not see any benefits from changing > this behavior probably? Sounds good, just wanted to check. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54751/new/ https://reviews.llvm.org/D54751 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
