clayborg added inline comments.
================ Comment at: include/lldb/Symbol/ObjectFile.h:569 + /// Returns the base file address of an object file (also known as the + /// preferred load address or image base address). This is typically the file ---------------- lemo wrote: > "file address" can mean an offset within a container file. > > to avoid any confusion I'd use "base address" (or "image base address") "file address" is the correct LLDB term so I would leave this as is. File addresses in LLDB are addresses as they are represented within the object file itself. Load addresses at unique and map to a single address in a live process where shared libraries are slid around. So "file address" is the correct LLDB term. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55356/new/ https://reviews.llvm.org/D55356 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
