grimar added a comment. In D55995#1339099 <https://reviews.llvm.org/D55995#1339099>, @clayborg wrote:
> The changes from "constexpr" to "const" might introduce global constructors > in the shared library which is what we were trying to avoid. The less work > that the LLDB shared library does on load the better. We might need to use a > macro that expands to "constexpr" for non windows and to "const" for windows > in a private LLDB header (PropertyDefinition.h?) Thanks for looking, Greg. Initially, I thought only MSVS 2015 is affected, but looking at the comments in the wild (https://developercommunity.visualstudio.com/content/problem/18155/msvc-2017-c-fatal-error-c1001-constexpr-initializa.html), seems it might be an issue for MSVS 2017 too. So I am going to implement your suggestion. Seems lldb.lldb-defines.h file we already have is a good place for a new macro definition. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55995/new/ https://reviews.llvm.org/D55995 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
