clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.

So it seems like DynamicLoaderWindowsDYLD is not doings its job correctly and 
it needs to be fixed. DynamicLoaderWindowsDYLD is responsible for setting all 
of the section load addresses correctly using an abstract lldb_private::Process 
plug-in. No special calls should be added if that is possible. We have someone 
working on lldb-server.exe and then we will have two clients for 
DynamicLoaderWindowsDYLD: ProcessWindows and ProcessGDBRemote. 
DynamicLoaderWindowsDYLD should work for any lldb_private::Process subclass 
without the need to call back into a specific lldb_private::Process subclass 
method.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56237/new/

https://reviews.llvm.org/D56237



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to